Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android build fixes #207

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Android build fixes #207

merged 1 commit into from
Nov 8, 2024
+2 −0

Conversation

lhoward
Copy link
Contributor

@lhoward lhoward commented Nov 8, 2024

No description provided.

@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Nov 8, 2024
Lukasa
Lukasa approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ✨

@Lukasa Lukasa enabled auto-merge (squash) November 8, 2024 11:23
@Lukasa Lukasa merged commit 2be7251 into apple:main Nov 8, 2024
43 checks passed
@marcprux marcprux mentioned this pull request Jan 7, 2025
Merged
Lukasa pushed a commit that referenced this pull request Jan 8, 2025
@marcprux
Add Android import for IPAddressNameTests (#217)
274f866 
Following on #183 and
#207, we need to `import
Android` in `IPAddressTests.swift` to get `inet_pton` and `in6_addr`.

With this addition, tests pass on Android again.
@marcprux
Copy link
Contributor

@Lukasa Could we have a swift-certificates 1.6.2 patch release that includes this? Android projects that depend on jwt-kit are currently failing because of this transitive dependency.

@Lukasa
Copy link
Contributor

Lukasa commented Jan 10, 2025

Sure, I can get a release out next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lhoward @marcprux @Lukasa