Add dependency-analysis-gradle-plugin #3158
Merged
+106
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The Dependency Analysis Gradle Plugin (DAGP) detects the following problems with dependencies: unused dependencies, used transitive dependencies that should be declared directly, dependencies declared on the wrong configuration. Modifications: - Add new plugin dependency as part of our `servicetalk-gradle-plugin-internal`; - Apply it for libraries to enable `projectHealth` task; - Apply it for root projects to enable `buildHealth` task that generates full report in a file; - Add `dependencyAnalysis` task and bundle it as part of `quality` task to allow validation via CI pipelines; - Make sure `copySourcesForJersey3` task always executes before `dependencyAnalysis` as it depends on copied source code; Result: We can automatically detect issues with dependencies.
Second iteration did not help.
This reverts commit dd2ffbb.
idelpivnitskiy
commented
Jan 3, 2025
| issues { | ||
| all { | ||
| onAny { | ||
| severity("warn") // FIXME: switch to "fail" when all issues are addressed |
There was a problem hiding this comment.
This will change after all issues are resolved, will require a few follow-up PRs
| @@ -68,6 +68,13 @@ tasks.sourcesJar.dependsOn(copySourcesForJersey3) | |||
| tasks.compileJava.dependsOn(copySourcesForJersey3) | |||
| tasks.processTestResources.dependsOn(copySourcesForJersey3) | |||
| tasks.compileTestJava.dependsOn(copySourcesForJersey3) | |||
| afterEvaluate { | |||
| if (tasks.findByName("projectHealth")) { | |||
| tasks.withType(com.autonomousapps.tasks.CodeSourceExploderTask) { | |||
There was a problem hiding this comment.
I tried many different ways to avoid this duplication. Unfortunately, nothing worked without bringing more problems. My gradle-foo is exhausted at this point 😢
Scottmitch
approved these changes
Jan 3, 2025
| apply plugin: "io.servicetalk.servicetalk-gradle-plugin-internal-root" | ||
|
|
||
| // Unfortunately, we can not make this validation part of our servicetalk-gradle-plugin-internal because it requires | ||
| // JDK11 while we build and package out plugin with JDK8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The Dependency Analysis Gradle Plugin (DAGP) detects the following
problems with dependencies: unused dependencies, used transitive
dependencies that should be declared directly, dependencies declared on
the wrong configuration.
Modifications:
build.gradlefile;buildHealthtask part of thequalitytask;copySourcesForJersey3task always executes beforedependency-analysis as it depends on copied source code;
Result:
We can automatically detect issues with dependencies.
More info: https://github.com/autonomousapps/dependency-analysis-gradle-plugin