Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadbalancer-experimental: Unify the Host.weight() methods #3146

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

bryce-anderson
Copy link
Contributor

@bryce-anderson bryce-anderson commented Dec 18, 2024

Motivation:

We have a few Host related weight methods, but they have slightly different names. Worse yet, we don't use them properly when adjusting weights.

Modifications:

Rename the LoadBalancerObserver.Host.loadBalancingWeight() to simply .weight()

Motivation:

We have a few Host related weight methods, but they're slightly
different named. Worse yet, we don't use them properly when
adjusting weights.

Modifications:

Rename the LoadBalancerObserver.Host.loadBalancingWeight() to
simply .weight()
@bryce-anderson bryce-anderson merged commit 5fb80d0 into apple:main Dec 19, 2024
11 checks passed
@bryce-anderson bryce-anderson deleted the bl_anderson/weightsFix branch December 19, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants