loadbalancer-experimental: change host set update events #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: As discussed in apple#3140, we need to adjust some of the LoadBalancerObserver callbacks to make the events more clear and also preserve important order characteristics. Modifications: - Remove the size parameters from the `onServiceDiscoveryEvent` method as that required us to either precompute the size change or emit the event later than host observer creation events. - Change the `onHostSetChanged` method to take two collections: one reflecting the previous set and the new set, both after manipulations where done such as prioritization and subsetting.
...oadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/LoadBalancerObserver.java
Outdated
Show resolved
Hide resolved
...ider/src/main/java/io/servicetalk/loadbalancer/experimental/DefaultLoadBalancerObserver.java
Outdated
Show resolved
Hide resolved
...ider/src/main/java/io/servicetalk/loadbalancer/experimental/DefaultLoadBalancerObserver.java
Outdated
Show resolved
Hide resolved
...ider/src/main/java/io/servicetalk/loadbalancer/experimental/DefaultLoadBalancerObserver.java
Outdated
Show resolved
Hide resolved
...cetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/HostSelector.java
Outdated
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As discussed in #3140, we need to adjust some of the LoadBalancerObserver callbacks to make the events more clear and also preserve important order characteristics.
Modifications:
onServiceDiscoveryEventmethod as that required us to either precompute the size change or emit the event later than host observer creation events.onHostSetChangedmethod to take two collections: one reflecting the previous set and the new set, both after manipulations where done such as prioritization and subsetting.