loadbalancer-experimental: javadoc cleanup and minor fixes #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor adjustments to indentation, validation, formatting, in code and javadoc.
idelpivnitskiy
commented
Dec 13, 2024
...lk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/BaseHostSelector.java
Outdated
Show resolved
Hide resolved
...talk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/RequestTracker.java
Show resolved
Hide resolved
...dbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/ConnectionPoolPolicies.java
Show resolved
Hide resolved
...adbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/LoadBalancingPolicies.java
Show resolved
Hide resolved
...oadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/LoadBalancerObserver.java
Show resolved
Hide resolved
...oadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/LoadBalancerObserver.java
Show resolved
Hide resolved
...oadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/LoadBalancerObserver.java
Show resolved
Hide resolved
...adbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/LoadBalancingPolicies.java
Show resolved
Hide resolved
...oadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/LoadBalancerObserver.java
Show resolved
Hide resolved
...oadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/LoadBalancerObserver.java
Show resolved
Hide resolved
...adbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/LoadBalancingPolicies.java
Show resolved
Hide resolved
...talk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/RequestTracker.java
Show resolved
Hide resolved
...talk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/RequestTracker.java
Outdated
Show resolved
Hide resolved
...adbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/OutlierDetectorConfig.java
Outdated
Show resolved
Hide resolved
...dbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/ConnectionPoolPolicies.java
Show resolved
Hide resolved
bryce-anderson
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor adjustments to indentation, validation, formatting, in code and javadoc.
Also reduced visibility where it was possible. Even if those methods are currently in pkg-private classes, it may help to start with minimal visibility on methods to avoid accidental API leaks when we make classes public in the future.