Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadbalancer: move DefaultLoadBalancer out of experimental #3136

Merged

Conversation

bryce-anderson
Copy link
Contributor

Motivation:

We've had DefaultLoadBalancer running in place of round-robin for
some time and it looks good. It's time to move it into the main
package and prepare to remove RoundRobinLoadBalancer.

Modifications:

Most most of the contents of servicetalk-loadbalancer-experimental
to the servicetalk-loadbalancer package.

@bryce-anderson
Copy link
Contributor Author

the PR #3137 has one more commit to show how the migration provider will be folded into the servicetalk-loadbalancer package.

@idelpivnitskiy
Copy link
Member

Ok, looks like you are ready for the move 🚀
Let me put this PR in a draft mode for a little, while I go over LB API locally to make sure there are no other changes we should do before the move.

@idelpivnitskiy idelpivnitskiy marked this pull request as draft December 12, 2024 22:28
@bryce-anderson bryce-anderson marked this pull request as ready for review December 19, 2024 18:43
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Currently this page is not discoverable. We should incorporate it into https://apple.github.io/servicetalk//servicetalk-loadbalancer/SNAPSHOT/index.html. Might be a follow-up PR, up to you.

  2. This file has a few links that contain -experimental, those will be broken after merging this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you think, should we move this one to servicetalk-client-api instead? Feels like it's similar to SD or LB API we already have there and also intended to be used across modules: http-netty, grpc-netty.

settings.gradle Outdated Show resolved Hide resolved
Copy link
Member

@idelpivnitskiy idelpivnitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bryce-anderson bryce-anderson merged commit e4d4418 into apple:main Dec 19, 2024
11 checks passed
@bryce-anderson bryce-anderson deleted the bl_anderson/DefaultLBNonExperimental branch December 19, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants