-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loadbalancer: move DefaultLoadBalancer out of experimental #3136
loadbalancer: move DefaultLoadBalancer out of experimental #3136
Conversation
the PR #3137 has one more commit to show how the migration provider will be folded into the |
Ok, looks like you are ready for the move 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Currently this page is not discoverable. We should incorporate it into https://apple.github.io/servicetalk//servicetalk-loadbalancer/SNAPSHOT/index.html. Might be a follow-up PR, up to you.
-
This file has a few links that contain
-experimental
, those will be broken after merging this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you think, should we move this one to servicetalk-client-api
instead? Feels like it's similar to SD or LB API we already have there and also intended to be used across modules: http-netty, grpc-netty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Motivation:
We've had DefaultLoadBalancer running in place of round-robin for
some time and it looks good. It's time to move it into the main
package and prepare to remove RoundRobinLoadBalancer.
Modifications:
Most most of the contents of servicetalk-loadbalancer-experimental
to the servicetalk-loadbalancer package.