loadbalancer-experimental: make ConnectionPoolPolicy consistent #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We typically have a 'ies' class for the static helper methods, but right now we stuff all that into ConnectionPoolPolicy. We also tried to hide all the details by making the ConnectionPoolPolicy a data carrier instead of having any behavior, but that makes some extra noise around conversions. Modifications: - Make ConnectionPoolPolicy follow the pattern in LoadBalancingPolicy, in that it's a factory but the constructor and methods are package private to control proliferation. - Remove the internal time ConnetionPoolFactory which is now subsumed by ConnectionPoolPolicy. - Make ConnectionPoolPolicies to follow the pattern established patterns. Result: More consistent code.
idelpivnitskiy
approved these changes
Dec 11, 2024
| this.linearSearchSpace = ensurePositive(linearSearchSpace, "linearSearchSpace"); | ||
| } | ||
| } | ||
| abstract ConnectionSelector<C> buildConnectionSelector(String lbDescription); |
There was a problem hiding this comment.
Do you think we are ready to open this up together with ConnectionSelector? If yes, we will be able to change from an abstract class to an interface (could be a follow up, no need to mix all in this PR).
There was a problem hiding this comment.
Good question, and I thought about it as well. The same question applies to the LoadBalancingPolicy.
I'm torn: it does feel like it should be an interface but otoh this pattern lets us not commit to any specific API. Let's discuss it in a followup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We typically have a 'ies' class for the static helper methods, but right now we stuff all that into ConnectionPoolPolicy. We also tried to hide all the details by making the ConnectionPoolPolicy a data carrier instead of having any behavior, but that makes some extra noise around conversions.
Modifications:
Result:
More consistent code.