Add validation for H1ProtocolConfigBuilder setters
#2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `H1ProtocolConfigBuilder` does not validate incoming int parameters.
idelpivnitskiy
commented
Dec 20, 2023
| @@ -67,6 +67,9 @@ public H1ProtocolConfigBuilder headersFactory(final HttpHeadersFactory headersFa | |||
| * @return {@code this} | |||
| */ | |||
| public H1ProtocolConfigBuilder maxPipelinedRequests(final int maxPipelinedRequests) { | |||
| if (maxPipelinedRequests <= 0) { | |||
| throw new IllegalArgumentException("maxPipelinedRequests: " + maxPipelinedRequests + " (expected >0)"); | |||
There was a problem hiding this comment.
I will send a follow-up later to extract this validation into a common utility for ST
There was a problem hiding this comment.
My promised follow-up: #2797
daschl
approved these changes
Dec 21, 2023
| @@ -67,6 +67,9 @@ public H1ProtocolConfigBuilder headersFactory(final HttpHeadersFactory headersFa | |||
| * @return {@code this} | |||
| */ | |||
| public H1ProtocolConfigBuilder maxPipelinedRequests(final int maxPipelinedRequests) { | |||
| if (maxPipelinedRequests <= 0) { | |||
| throw new IllegalArgumentException("maxPipelinedRequests: " + maxPipelinedRequests + " (expected >0)"); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
H1ProtocolConfigBuilderdoes not validate incoming int parameters.