Extract round-robin host selection from the NewRoundRobinLoadBalancer #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We want to be able to swap out load balancer algorithms but right now that is in-lined in the same file as the host set management. Modifications: - Extract the host selection algorithm into it's own class RoundRobinSelector.
bryce-anderson
commented
Oct 31, 2023
servicetalk-loadbalancer/src/main/java/io/servicetalk/loadbalancer/RoundRobinSelector.java
Show resolved
Hide resolved
bryce-anderson
commented
Oct 31, 2023
...cetalk-loadbalancer/src/main/java/io/servicetalk/loadbalancer/NewRoundRobinLoadBalancer.java
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Nov 1, 2023
servicetalk-loadbalancer/src/main/java/io/servicetalk/loadbalancer/HostSelector.java
Outdated
Show resolved
Hide resolved
servicetalk-loadbalancer/src/main/java/io/servicetalk/loadbalancer/RoundRobinSelector.java
Outdated
Show resolved
Hide resolved
tkountis
approved these changes
Nov 1, 2023
servicetalk-loadbalancer/src/main/java/io/servicetalk/loadbalancer/HostSelector.java
Outdated
Show resolved
Hide resolved
servicetalk-loadbalancer/src/main/java/io/servicetalk/loadbalancer/HostSelector.java
Outdated
Show resolved
Hide resolved
servicetalk-loadbalancer/src/main/java/io/servicetalk/loadbalancer/RoundRobinSelector.java
Outdated
Show resolved
Hide resolved
| * This method will be called concurrently with other selectConnection calls and | ||
| * hostSetChanged calls and must be thread safe under those conditions. | ||
| */ | ||
| Single<C> selectConnection(Predicate<C> selector, @Nullable ContextMap context, |
There was a problem hiding this comment.
wondering whether this needs to return a re-active primitive or a richer API that would rely less on extracting information from an exception.
There was a problem hiding this comment.
Are you thinking of something similar to the Scala Try?
It seems like we have three possible results: a synchronous connection, a synchronous failure, and an asynchronous connection which may fail. The asynchronous path makes it such that we must lift it to a Single at some point.
I'm going to merge this as it is for now and we can massage it later as it's deficiencies become more apparent with more examples.
bryce-anderson
deleted the
bl_anderson/extract_host_selection_algorithm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We want to be able to swap out load balancer algorithms but right
now that is in-lined in the same file as the host set management.
Modifications:
HostSelectorinterface.RoundRobinSelector.