ZipkinReporter: add trace logging for batching and encoded spans
#2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idelpivnitskiy
force-pushed
the
zipkin
branch
from
b1a8abc to
256cf7b
Compare
Motivation: In order to trace batching, trace level logging will be helpful. Modifications: - Log every accumulation; - Log every received span/list after encoding; Result: Easier to troubleshoot if there are any issues.
idelpivnitskiy
force-pushed
the
zipkin
branch
from
256cf7b to
a8f13f8
Compare
tkountis
reviewed
Nov 2, 2023
| .map(span -> { | ||
| // Always encode spans as list: https://github.com/apple/servicetalk/pull/2092 | ||
| final byte[] bytes = spanEncoder.encodeList(Collections.singletonList(span)); | ||
| LOGGER.trace("Encoded received span: {}, result={} bytes", span, bytes.length); |
There was a problem hiding this comment.
consider using the format key='value', helps with parsing to key-value strings for various formatters.
tkountis
approved these changes
Nov 2, 2023
daschl
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In order to trace batching, trace level logging will be helpful.
Modifications:
Result:
Easier to troubleshoot if there are any issues.