Clone the RR load balancer in preparation for refactoring #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We are going to start refactoring our load balancing components and in order to preserve the current stable form we're cloning it into another implementation (currently identical) which we can then start to pull apart. Modifications: - Add a private interface TestableLoadBalancer to expose a generic way of surfacing the current host set for tests. - Clone RoundRobinLoadBalancer into NewRoundRobinLoadBalancer which is currently identical to the original other than it's name. - Thread through the option to switch round robin load balancer implementation in the tests so we can detect regressions in the new implementation without text-copying the tests. When we get to the point we want to try it out we can start to surface the switch in the public interfaces. Result: What is the result of this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We are going to start refactoring our load balancing components
and in order to preserve the current stable form until we can build
confidence in it we're cloning RoundRobinLoadBalancer into another
class (currently identical other than name) which we can then start
to pull apart.
Modifications:
way of surfacing the current host set for tests.
is currently identical to the original other than it's name.
implementation in the tests so we can detect regressions in the
new implementation without text-copying the tests. When we get to
the point we want to try it out we can start to surface the switch
in the public interfaces.