-
Notifications
You must be signed in to change notification settings - Fork 182
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Stop using
servicetalk-dependencies
internally (#3055)
Motivation: Gradle interprets `*.module` files differently than the `pom.xml`. Because every module currently depends on `servicetalk-dependencies`, users pulled its `dependencyConstraints` in their build configurations with any servicetalk module as transitive dependency and got unintended changes for other dependencies. For example, `servicetalk-annotations` that has only jsr305 as a 3-party dependency still forces upgrade of jackson, protobuf, log4j, netty, and jersey for users because it depends on `servicetalk-dependencies`. Modifications: - Remove `servicetalk-dependencies` from every module, instead define every necessary dependency by its version number or import only required boms; - Update `servicetalk-dependencies` to include missed dependencies: opentelemetry, instrumentation, resilience4j; - Correct dependencies for all `-jersery3` modules to keep only what they use; - Move all `platform` dependencies from the top to their corresponding scope; - Regenerate lock files; Result: Users don't get unintended dependency upgrades because of the `*.module` file handling.
- Loading branch information
1 parent
249efc7
commit 9e310cc
Showing
189 changed files
with
401 additions
and
1,122 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,5 @@ | ||
# This is a Gradle generated file for dependency locking. | ||
# Manual edits can break the build and are not advised. | ||
# This file is expected to be part of source control. | ||
com.fasterxml.jackson:jackson-bom:2.16.2=compileClasspath,runtimeClasspath | ||
com.google.code.findbugs:jsr305:3.0.2=compileClasspath,runtimeClasspath | ||
com.google.protobuf:protobuf-bom:3.25.3=compileClasspath,runtimeClasspath | ||
io.netty:netty-bom:4.1.113.Final=compileClasspath,runtimeClasspath | ||
org.apache.logging.log4j:log4j-bom:2.23.1=compileClasspath,runtimeClasspath | ||
org.glassfish.jersey:jersey-bom:2.41=compileClasspath,runtimeClasspath | ||
empty=annotationProcessor,spotbugsPlugins,testAnnotationProcessor |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,5 @@ | ||
# This is a Gradle generated file for dependency locking. | ||
# Manual edits can break the build and are not advised. | ||
# This file is expected to be part of source control. | ||
com.fasterxml.jackson:jackson-bom:2.16.2=compileClasspath,runtimeClasspath | ||
com.google.code.findbugs:jsr305:3.0.2=compileClasspath,runtimeClasspath | ||
com.google.protobuf:protobuf-bom:3.25.3=compileClasspath,runtimeClasspath | ||
io.netty:netty-bom:4.1.113.Final=compileClasspath,runtimeClasspath | ||
org.apache.logging.log4j:log4j-bom:2.23.1=compileClasspath,runtimeClasspath | ||
org.glassfish.jersey:jersey-bom:2.41=compileClasspath,runtimeClasspath | ||
empty=annotationProcessor,spotbugsPlugins,testAnnotationProcessor,testFixturesAnnotationProcessor |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,10 @@ | ||
# This is a Gradle generated file for dependency locking. | ||
# Manual edits can break the build and are not advised. | ||
# This file is expected to be part of source control. | ||
com.fasterxml.jackson:jackson-bom:2.16.2=compileClasspath,runtimeClasspath | ||
com.google.code.findbugs:jsr305:3.0.2=compileClasspath,runtimeClasspath | ||
com.google.protobuf:protobuf-bom:3.25.3=compileClasspath,runtimeClasspath | ||
io.netty:netty-bom:4.1.113.Final=compileClasspath,runtimeClasspath | ||
io.netty:netty-buffer:4.1.113.Final=compileClasspath,runtimeClasspath | ||
io.netty:netty-common:4.1.113.Final=compileClasspath,runtimeClasspath | ||
org.apache.logging.log4j:log4j-bom:2.23.1=compileClasspath,runtimeClasspath | ||
org.glassfish.jersey:jersey-bom:2.41=compileClasspath,runtimeClasspath | ||
org.jctools:jctools-core:4.0.3=runtimeClasspath | ||
org.slf4j:slf4j-api:1.7.36=compileClasspath,runtimeClasspath | ||
empty=annotationProcessor,spotbugsPlugins,testAnnotationProcessor |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,7 @@ | ||
# This is a Gradle generated file for dependency locking. | ||
# Manual edits can break the build and are not advised. | ||
# This file is expected to be part of source control. | ||
com.fasterxml.jackson:jackson-bom:2.16.2=compileClasspath,runtimeClasspath | ||
com.google.code.findbugs:jsr305:3.0.2=compileClasspath,runtimeClasspath | ||
com.google.protobuf:protobuf-bom:3.25.3=compileClasspath,runtimeClasspath | ||
io.netty:netty-bom:4.1.113.Final=compileClasspath,runtimeClasspath | ||
org.apache.logging.log4j:log4j-bom:2.23.1=compileClasspath,runtimeClasspath | ||
org.glassfish.jersey:jersey-bom:2.41=compileClasspath,runtimeClasspath | ||
org.jctools:jctools-core:4.0.3=runtimeClasspath | ||
org.slf4j:slf4j-api:1.7.36=compileClasspath,runtimeClasspath | ||
empty=annotationProcessor,spotbugsPlugins,testAnnotationProcessor |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,5 @@ | ||
# This is a Gradle generated file for dependency locking. | ||
# Manual edits can break the build and are not advised. | ||
# This file is expected to be part of source control. | ||
com.fasterxml.jackson:jackson-bom:2.16.2=runtimeClasspath | ||
com.google.code.findbugs:jsr305:3.0.2=runtimeClasspath | ||
com.google.protobuf:protobuf-bom:3.25.3=runtimeClasspath | ||
io.netty:netty-bom:4.1.113.Final=runtimeClasspath | ||
org.apache.logging.log4j:log4j-bom:2.23.1=runtimeClasspath | ||
org.glassfish.jersey:jersey-bom:2.41=runtimeClasspath | ||
empty=annotationProcessor,compileClasspath,spotbugsPlugins,testAnnotationProcessor |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,10 @@ | ||
# This is a Gradle generated file for dependency locking. | ||
# Manual edits can break the build and are not advised. | ||
# This file is expected to be part of source control. | ||
com.fasterxml.jackson:jackson-bom:2.16.2=compileClasspath,runtimeClasspath | ||
com.google.code.findbugs:jsr305:3.0.2=runtimeClasspath | ||
com.google.protobuf:protobuf-bom:3.25.3=compileClasspath,runtimeClasspath | ||
io.github.resilience4j:resilience4j-circuitbreaker:1.7.1=compileClasspath,runtimeClasspath | ||
io.github.resilience4j:resilience4j-core:1.7.1=compileClasspath,runtimeClasspath | ||
io.netty:netty-bom:4.1.113.Final=compileClasspath,runtimeClasspath | ||
io.vavr:vavr-match:0.10.2=compileClasspath,runtimeClasspath | ||
io.vavr:vavr:0.10.2=compileClasspath,runtimeClasspath | ||
org.apache.logging.log4j:log4j-bom:2.23.1=compileClasspath,runtimeClasspath | ||
org.glassfish.jersey:jersey-bom:2.41=compileClasspath,runtimeClasspath | ||
org.slf4j:slf4j-api:1.7.36=runtimeClasspath | ||
org.slf4j:slf4j-api:1.7.30=runtimeClasspath | ||
empty=annotationProcessor,spotbugsPlugins,testAnnotationProcessor |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,7 @@ | ||
# This is a Gradle generated file for dependency locking. | ||
# Manual edits can break the build and are not advised. | ||
# This file is expected to be part of source control. | ||
com.fasterxml.jackson:jackson-bom:2.16.2=compileClasspath,runtimeClasspath | ||
com.google.code.findbugs:jsr305:3.0.2=compileClasspath,runtimeClasspath | ||
com.google.protobuf:protobuf-bom:3.25.3=compileClasspath,runtimeClasspath | ||
io.netty:netty-bom:4.1.113.Final=compileClasspath,runtimeClasspath | ||
org.apache.logging.log4j:log4j-bom:2.23.1=compileClasspath,runtimeClasspath | ||
org.glassfish.jersey:jersey-bom:2.41=compileClasspath,runtimeClasspath | ||
org.jctools:jctools-core:4.0.3=runtimeClasspath | ||
org.slf4j:slf4j-api:1.7.36=compileClasspath,runtimeClasspath | ||
empty=annotationProcessor,spotbugsPlugins,testAnnotationProcessor |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,7 @@ | ||
# This is a Gradle generated file for dependency locking. | ||
# Manual edits can break the build and are not advised. | ||
# This file is expected to be part of source control. | ||
com.fasterxml.jackson:jackson-bom:2.16.2=compileClasspath,runtimeClasspath | ||
com.google.code.findbugs:jsr305:3.0.2=compileClasspath,runtimeClasspath | ||
com.google.protobuf:protobuf-bom:3.25.3=compileClasspath,runtimeClasspath | ||
io.netty:netty-bom:4.1.113.Final=compileClasspath,runtimeClasspath | ||
org.apache.logging.log4j:log4j-bom:2.23.1=compileClasspath,runtimeClasspath | ||
org.glassfish.jersey:jersey-bom:2.41=compileClasspath,runtimeClasspath | ||
org.jctools:jctools-core:4.0.3=runtimeClasspath | ||
org.slf4j:slf4j-api:1.7.36=compileClasspath,runtimeClasspath | ||
empty=annotationProcessor,spotbugsPlugins,testAnnotationProcessor |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,7 @@ | ||
# This is a Gradle generated file for dependency locking. | ||
# Manual edits can break the build and are not advised. | ||
# This file is expected to be part of source control. | ||
com.fasterxml.jackson:jackson-bom:2.16.2=compileClasspath,runtimeClasspath | ||
com.google.code.findbugs:jsr305:3.0.2=compileClasspath,runtimeClasspath | ||
com.google.protobuf:protobuf-bom:3.25.3=compileClasspath,runtimeClasspath | ||
io.netty:netty-bom:4.1.113.Final=compileClasspath,runtimeClasspath | ||
org.apache.logging.log4j:log4j-bom:2.23.1=compileClasspath,runtimeClasspath | ||
org.glassfish.jersey:jersey-bom:2.41=compileClasspath,runtimeClasspath | ||
org.jctools:jctools-core:4.0.3=runtimeClasspath | ||
org.slf4j:slf4j-api:1.7.36=compileClasspath,runtimeClasspath | ||
empty=annotationProcessor,spotbugsPlugins,testAnnotationProcessor |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,7 @@ | ||
# This is a Gradle generated file for dependency locking. | ||
# Manual edits can break the build and are not advised. | ||
# This file is expected to be part of source control. | ||
com.fasterxml.jackson:jackson-bom:2.16.2=compileClasspath,runtimeClasspath | ||
com.google.code.findbugs:jsr305:3.0.2=compileClasspath,runtimeClasspath | ||
com.google.protobuf:protobuf-bom:3.25.3=compileClasspath,runtimeClasspath | ||
io.netty:netty-bom:4.1.113.Final=compileClasspath,runtimeClasspath | ||
org.apache.logging.log4j:log4j-bom:2.23.1=compileClasspath,runtimeClasspath | ||
org.glassfish.jersey:jersey-bom:2.41=compileClasspath,runtimeClasspath | ||
org.jctools:jctools-core:4.0.3=runtimeClasspath | ||
org.slf4j:slf4j-api:1.7.36=runtimeClasspath | ||
empty=annotationProcessor,spotbugsPlugins,testAnnotationProcessor |
Oops, something went wrong.