category/java/design

servicetalk-benchmarks/src/jmh/java/io/servicetalk/benchmark/CountDownLatchBenchmark.java

@@ -44,7 +44,7 @@ public class CountDownLatchBenchmark {
 
     private static final Object NULL = new Object();
 
-    private CountDownLatch latch = new CountDownLatch(0);
+    private final CountDownLatch latch = new CountDownLatch(0);
 
     @Nullable
     private volatile Object value = NULL;

servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/CopyOnWriteContextMap.java

@@ -334,7 +334,7 @@ public Key<?> forEach(final BiPredicate<Key<?>, Object> consumer) {
 
         @Override
         public int hashCode() {
-            return super.hashCode();
+            return System.identityHashCode(this);
         }
 
         @Override

servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/NoopAsyncContextProvider.java

@@ -252,7 +252,7 @@ public ContextMap copy() {
 
         @Override
         public int hashCode() {
-            return super.hashCode();
+            return System.identityHashCode(this);
         }
 
         @Override

servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/MulticastExactlyPublisherTest.java

@@ -44,7 +44,7 @@
 @Timeout(60)
 class MulticastExactlyPublisherTest {
     private TestPublisher<Integer> source = new TestPublisher.Builder<Integer>().disableAutoOnSubscribe().build();
-    private TestSubscription subscription = new TestSubscription();
+    private final TestSubscription subscription = new TestSubscription();
 
     @Test
     void emitItemsAndThenError() {

servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/OnErrorResumePublisherTest.java

@@ -35,8 +35,8 @@
 final class OnErrorResumePublisherTest {
 
     private final TestPublisherSubscriber<Integer> subscriber = new TestPublisherSubscriber<>();
-    private TestPublisher<Integer> first = new TestPublisher<>();
-    private TestPublisher<Integer> second = new TestPublisher<>();
+    private final TestPublisher<Integer> first = new TestPublisher<>();
+    private final TestPublisher<Integer> second = new TestPublisher<>();
 
     @Test
     void testFirstComplete() {

servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/completable/CompletableToPublisherTest.java

@@ -42,7 +42,7 @@ class CompletableToPublisherTest {
     @RegisterExtension
     static final ExecutorExtension<Executor> EXEC = ExecutorExtension.withCachedExecutor().setClassLevel(true);
 
-    private TestPublisherSubscriber<String> subscriber = new TestPublisherSubscriber<>();
+    private final TestPublisherSubscriber<String> subscriber = new TestPublisherSubscriber<>();
 
     @Test
     void invalidRequestNCancelsCompletable() {

servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/completable/CompletableToSingleTest.java

@@ -36,7 +36,7 @@ class CompletableToSingleTest {
     @RegisterExtension
     static final ExecutorExtension<Executor> EXEC = ExecutorExtension.withCachedExecutor().setClassLevel(true);
 
-    private TestSingleSubscriber<Void> subscriber = new TestSingleSubscriber<>();
+    private final TestSingleSubscriber<Void> subscriber = new TestSingleSubscriber<>();
 
     @Test
     void noTerminalSucceeds() {

servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/publisher/AbstractWhenCancelTest.java

@@ -37,7 +37,7 @@ public abstract class AbstractWhenCancelTest {
 
     private final TestPublisher<String> publisher = new TestPublisher<>();
     private final TestPublisherSubscriber<String> subscriber = new TestPublisherSubscriber<>();
-    private TestSubscription subscription = new TestSubscription();
+    private final TestSubscription subscription = new TestSubscription();
 
     @Test
     void testCancelAfterEmissions() {

servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/publisher/ForEachTest.java

@@ -35,7 +35,7 @@ final class ForEachTest {
     private TestPublisher<Integer> source;
     private Consumer<Integer> forEach;
     private Cancellable cancellable;
-    private TestSubscription subscription = new TestSubscription();
+    private final TestSubscription subscription = new TestSubscription();
 
     @SuppressWarnings("unchecked")
     @BeforeEach

servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/publisher/ScalarResultPublisherTest.java

@@ -31,7 +31,7 @@
 
 class ScalarResultPublisherTest {
 
-    private TestPublisherSubscriber<String> subscriber = new TestPublisherSubscriber<>();
+    private final TestPublisherSubscriber<String> subscriber = new TestPublisherSubscriber<>();
 
     @Test
     void testJust() {

servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/single/ConcatWithCompletableTest.java

@@ -35,8 +35,8 @@ class ConcatWithCompletableTest {
     @RegisterExtension
     static final ExecutorExtension<Executor> EXEC = ExecutorExtension.withCachedExecutor().setClassLevel(true);
     private final TestSingleSubscriber<String> listener = new TestSingleSubscriber<>();
-    private LegacyTestSingle<String> single = new LegacyTestSingle<>();
-    private LegacyTestCompletable completable = new LegacyTestCompletable();
+    private final LegacyTestSingle<String> single = new LegacyTestSingle<>();
+    private final LegacyTestCompletable completable = new LegacyTestCompletable();
 
     @Test
     void concatWaitsForCompletableSuccess() {

servicetalk-gradle-plugin-internal/src/main/resources/io/servicetalk/gradle/plugin/internal/pmd/basic.xml

@@ -110,9 +110,33 @@
     <exclude name="InsufficientStringBufferDeclaration"/>
   </rule>
 
-  <rule ref="category/java/design.xml/CollapsibleIfStatements"/>
-  <rule ref="category/java/design.xml/MutableStaticState" />
-  <rule ref="category/java/design.xml/SimplifiedTernary"/>
+  <rule ref="category/java/design.xml">
+    <exclude name="AbstractClassWithoutAnyMethod"/>
+    <exclude name="AvoidCatchingGenericException"/>
+    <exclude name="AvoidDeeplyNestedIfStmts"/>
+    <exclude name="AvoidRethrowingException"/>
+    <exclude name="AvoidThrowingNullPointerException"/>
+    <exclude name="AvoidThrowingRawExceptionTypes"/>
+    <exclude name="AvoidUncheckedExceptionsInSignatures"/>
+    <exclude name="CognitiveComplexity"/>
+    <exclude name="CouplingBetweenObjects"/>
+    <exclude name="CyclomaticComplexity"/>
+    <exclude name="DataClass"/>
+    <exclude name="DoNotExtendJavaLangError"/>
+    <exclude name="ExcessiveImports"/>
+    <exclude name="ExcessiveParameterList"/>
+    <exclude name="ExcessivePublicCount"/>
+    <exclude name="GodClass"/>
+    <exclude name="LawOfDemeter"/>
+    <exclude name="NPathComplexity"/>
+    <exclude name="NcssCount"/>
+    <exclude name="SignatureDeclareThrowsException"/>
+    <exclude name="SingularField"/>
+    <exclude name="SwitchDensity"/>
+    <exclude name="TooManyFields"/>
+    <exclude name="TooManyMethods"/>
+    <exclude name="UseUtilityClass"/>
+  </rule>
 
   <!-- generated -->
   <exclude-pattern>.*/generated/source/proto/.*</exclude-pattern>

servicetalk-grpc-netty/src/test/java/io/servicetalk/grpc/customtransport/CustomTransportTest.java

@@ -61,6 +61,8 @@ void testCustomTransport(final ServiceType serviceType) throws Exception {
             // Build the client with the custom transport and bridge to server's transport.
             Tester.TesterClient client = new Tester.ClientFactory() {
                 @Override
+                @SuppressWarnings("PMD.UselessOverridingMethod")
+                // Override to alter visibility modifier
                 public TesterClient newClient(final GrpcClientCallFactory factory) {
                     return super.newClient(factory);
                 }

servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/ProxyResponseException.java

@@ -43,7 +43,8 @@ public HttpResponseStatus status() {
     }
 
     @Override
-    public String toString() {
+    @SuppressWarnings("PMD.UselessOverridingMethod")
+    public String toString() {  // FIXME: 0.43 - remove method that was kept only for ABI backward compatibility
         return super.toString();
     }
 }

servicetalk-opentracing-asynccontext/src/test/java/io/servicetalk/opentracing/asynccontext/AsyncContextInMemoryScopeManagerTest.java

@@ -36,7 +36,7 @@ class AsyncContextInMemoryScopeManagerTest {
     @Mock
     private InMemorySpan mockSpan2;
 
-    private AsyncContextInMemoryScopeManager scopeManager = (AsyncContextInMemoryScopeManager) SCOPE_MANAGER;
+    private final AsyncContextInMemoryScopeManager scopeManager = (AsyncContextInMemoryScopeManager) SCOPE_MANAGER;
 
     @BeforeEach
     public void setup() {

servicetalk-transport-netty-internal/src/test/java/io/servicetalk/transport/netty/internal/FlushStrategiesTest.java

@@ -38,7 +38,7 @@ class FlushStrategiesTest {
     private FlushSender flushSender;
     private TestPublisher<String> durationSource;
     private WriteEventsListener listener;
-    private TestSubscription subscription = new TestSubscription();
+    private final TestSubscription subscription = new TestSubscription();
 
     @BeforeEach
     public void setUp() {

servicetalk-transport-netty-internal/src/test/java/io/servicetalk/transport/netty/internal/RequestResponseCloseHandlerTest.java

@@ -290,9 +290,9 @@ class Scenarios {
         private RequestResponseCloseHandler h;
         @Nullable
         private CloseEvent observedEvent;
-        private AtomicBoolean closed = new AtomicBoolean();
-        private AtomicBoolean inputShutdown = new AtomicBoolean();
-        private AtomicBoolean outputShutdown = new AtomicBoolean();
+        private final AtomicBoolean closed = new AtomicBoolean();
+        private final AtomicBoolean inputShutdown = new AtomicBoolean();
+        private final AtomicBoolean outputShutdown = new AtomicBoolean();
         private SocketChannelConfig scc;
 
         /**