Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added password rules for ana.co.jp #765

Merged
merged 1 commit into from
May 29, 2024

Conversation

rohitpoks
Copy link
Contributor

@rohitpoks rohitpoks commented May 28, 2024

Added rules that conform to the requirements from the sign up page (https://www.ana.co.jp/en/us/amc/join-amc/).

Below are screenshots from the sign up page demonstrating these requirements:

Screenshot 2024-05-28 at 4 10 28 PM Screenshot 2024-05-29 at 4 12 23 AM

Overall Checklist

for password-rules.json

  • The given rule isn't particularly standard and obvious for password managers
  • Generated passwords have been tested from this rule using the Password Rules Validation Tool
  • Information has been included about the website's requirements (eg. screenshots, error messages, steps during experimentation, etc.)
  • The PR isn't documenting something that would be a common practice among password managers (e.g. minimal length of 6)

Added rules that conform to the following requirements from the sign up page (https://www.ana.co.jp/en/us/amc/join-amc/):
1. Only alphabets and numbers
2. 8-16 alphanumeric characters in total
@@ -41,6 +41,9 @@
"americanexpress.com": {
"password-rules": "minlength: 8; maxlength: 20; max-consecutive: 4; required: lower, upper; required: digit; allowed: [%&_?#=];"
},
"ana.co.jp": {
"password-rules": "minlength: 8; maxlength: 16; required: digit; required: upper,lower;"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I got from the screenshot is that only alphanumeric characters are allowed, in which case shouldn't this use "allowed:" like the one below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Site requires a combination of alphabets and numbers (see image below). Attached it to the original PR comment
Screenshot 2024-05-29 at 4 12 23 AM

Copy link
Collaborator

@jmulani jmulani May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it required that a password on this site has to have both a number and an upper/lower case letter? It doesn't seem like that is the case from the screenshots, which gives me the same interpretation as Jason.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it requires passwords to have both a number and an alphabet. Passwords such as "abcdefghij" and "123456789" spit out the error message "Please enter your web password by combining alphabets and numbers". I believe the error message is kind of vague because it's translated from Japanese.

@jmulani jmulani merged commit 3c55d58 into apple:main May 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants