Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce max password length on costco.com #758

Merged
merged 1 commit into from
May 13, 2024

Conversation

sjbarag
Copy link
Contributor

@sjbarag sjbarag commented May 13, 2024

The rendered password input has maxlength="16", and the "Create Account" page lists "Use between 8 and 16 characters". Decrease the maximum password length.

Overall Checklist

for password-rules.json

  • The given rule isn't particularly standard and obvious for password managers
  • Generated passwords have been tested from this rule using the Password Rules Validation Tool
  • Information has been included about the website's requirements (eg. screenshots, error messages, steps during experimentation, etc.)
  • The PR isn't documenting something that would be a common practice among password managers (e.g. minimal length of 6)

Screenshots

image

image

The rendered password input has `maxlength="16"`, and the "Create
Account" page lists "Use between 8 and 16 characters". Decrease the
maximum password length.
@rmondello rmondello merged commit 06deeed into apple:main May 13, 2024
5 checks passed
@sjbarag
Copy link
Contributor Author

sjbarag commented May 13, 2024

Thanks @rmondello! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants