Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aeon.co.jp #756

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Add aeon.co.jp #756

merged 3 commits into from
Sep 24, 2024

Conversation

tockrock
Copy link
Contributor

@tockrock tockrock commented May 5, 2024

Overall Checklist

for password-rules.json

  • The given rule isn't particularly standard and obvious for password managers
  • Generated passwords have been tested from this rule using the Password Rules Validation Tool
  • Information has been included about the website's requirements (eg. screenshots, error messages, steps during experimentation, etc.)
    スクリーンショット 2024-05-05 17 18 39

半角英数字・記号 8ケタ
使用可能な記号 # $ + - . / : = ? @ [ ] ^ _ | ~
※英字(または記号)・数字の各1文字以上の組み合わせ
※生年月日、電話番号、名前、カード番号、ID、メールアドレスと同じ文字列などは設定不可
※「000…」「aaa…」など、同じ英数字・記号は連続3文字まで利用可能(4文字以上は利用不可)

Translated:

Half-width alphanumeric & symbols, 8 characters
Usable symbols: # $ + - . / : = ? @ [ ] ^ _ | ~
*At least one letter (or symbol) and one numeral must be included in the combination.
*Strings that are the same as your birth date, telephone number, name, card number, ID, or email address cannot be set.
*The same letter, number, or symbol can be used consecutively up to 3 times (4 or more consecutive identical characters are not allowed).

(Half-width means non-2byte characters more or less)

  • The PR isn't documenting something that would be a common practice among password managers (e.g. minimal length of 6)

for change-password-URLs.json

  • There is no Well-Known URL for Changing Passwords (https://example.com/.well-known/change-password)
  • The URL either makes the experience better or no worse than being directed to just the domain in a non-logged-in state

@tockrock
Copy link
Contributor Author

Fixed merge conflict. Is there anything I need to do to get this reviewed?

@rmondello rmondello merged commit fee7264 into apple:main Sep 24, 2024
5 checks passed
@tockrock
Copy link
Contributor Author

Thanks!

@rmondello
Copy link
Contributor

Thank you for the contribution, and very sorry about the delay!

@tockrock tockrock deleted the aeon branch September 24, 2024 16:33
rmondello pushed a commit to rmondello/password-manager-resources that referenced this pull request Nov 6, 2024
* Add rule for aeon.co.jp

* Add change password url for aeon.co.jp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants