Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scottscheapflights.com / going.com #751

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

ezfe
Copy link
Contributor

@ezfe ezfe commented Feb 25, 2024

Overall Checklist

for shared-credentials.json

  • There's evidence the domains are currently related (SSL certificates, DNS entries, valid links between sites, legal documents etc.)
  • If using from and to, the new group, the from domain(s) redirect to the to domain to log in.

Evidence: scottscheapflights.com redirects to going.com and going.com references scottscheapflights.com

@ezfe
Copy link
Contributor Author

ezfe commented Feb 25, 2024

Alright I've run multiple scripts and hand-verified the order and can't figure out what the linter doesn't like

Copy link
Contributor

@rmondello rmondello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve this and then I’ll clean up the linter after.

@rmondello rmondello merged commit 967831e into apple:main Feb 26, 2024
4 of 5 checks passed
@ezfe ezfe deleted the going.com branch February 26, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants