fix: prevent filtering out synonyms #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Lopez <[email protected]>
|
Will this be merged soon? |
|
I am closing this PR as the intent behind it should already be addressed by using the unparsed suggestions https://opensource.appbase.io/reactive-manual/advanced/customsuggestions.html. If there is a bug with that behavior, we should address it in ReactiveSearch rather than here. I did check the current codebase, and it should work as intended from what I can tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synonyms are incorrectly filtered out.
Related issue: #29
A corresponding PR in
reactivesearchwill be necessary to callgetSuggestionswithoutcurrentValue