Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix CurlImpersonateHttpClient cookies handler #946

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: fix CurlImpersonateHttpClient cookies handler #946

wants to merge 3 commits into from
+106 −1

Conversation

Mantisus
Copy link
Collaborator

Description

  • fix cookie handling. Behavior alignment with HttpxHttpClient.

Issues

@Mantisus Mantisus requested review from janbuchar and vdusek January 30, 2025 14:18
@janbuchar
Copy link
Collaborator

Could you add a test please?

@Mantisus
Copy link
Collaborator Author

Could you add a test please?

Yeah sure, but I need that PR #947 for these tests 🙂

@Mantisus Mantisus self-assigned this Jan 30, 2025
@Mantisus
Copy link
Collaborator Author

Added tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbuchar janbuchar Awaiting requested review from janbuchar

@vdusek vdusek Awaiting requested review from vdusek

Assignees

@Mantisus Mantisus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mantisus @janbuchar