ci: Use the release-metadata action #597
Conversation
janbuchar
commented
Oct 16, 2024
•
janbuchar
commented
- closes Deprecated variables in git_cliff_core::changelog #598
janbuchar
added
t-tooling
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If issue is not linked to the pull request then estimate the pull request!
There was a problem hiding this comment.
If issue is not linked to the pull request then estimate the pull request!
| lint_check: | ||
| name: Lint check | ||
| uses: apify/workflows/.github/workflows/python_lint_check.yaml@main | ||
|
|
||
| type_check: | ||
| name: Type check | ||
| uses: apify/workflows/.github/workflows/python_type_check.yaml@main | ||
|
|
||
| unit_tests: | ||
| name: Unit tests | ||
| uses: apify/workflows/.github/workflows/python_unit_tests.yaml@main |
There was a problem hiding this comment.
On a manual release, this really seems redundant. Also, see #469
There was a problem hiding this comment.
Currently, it is not redundant, since we don't have any additional trigger of code checks for the master (only for PRs).
|
I'm thinking if |
.github/workflows/pre_release.yaml
Outdated
| # Trigger a beta version release (pre-release) on push to the master branch. | ||
| push: | ||
| branches: | ||
| - use-release-metadata-action # TODO |
There was a problem hiding this comment.
how is this supposed to be working? canary builds should be done only on the default branch
There was a problem hiding this comment.
that's so that I can test the workflow against this branch, I intend to change it to master before merging
