Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Actor.charge() #346
feat: Actor.charge() #346
Changes from 30 commits
7529857
7f786f8
32982bb
1897d08
6461f01
0d558b6
044ae6c
5d2a678
38ff1b6
582bb0d
fe38c87
b3dafeb
c58aae6
8dc3422
02f1953
35a378f
e9482fc
9925108
973b19f
72ff36a
b5ebe79
1bb2dc3
7d4263c
6ef64a6
c312681
da8daf3
dbd8be6
99d13f2
744f4a9
1aef01d
a6ff016
c4f01a2
06b80de
c476944
ec72e6f
346cc98
31ad976
01832c8
eee72cb
c16d554
04c4790
915cb31
a3e78f2
b080ae6
e2ff873
4839a74
292ab3e
30ac39a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would maybe add
asArray
helper to simplify this, now you do it twice in the same method.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I guess with a third occurence I'd start to consider it 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was actually surprised we dont have it here already, I can imagine there are other places that should use it. But yeah, lets not derail here.