Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump apify ui components to an existing version #828

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

vladfrangu
Copy link
Member

@vladfrangu vladfrangu commented Jan 12, 2024

In the time where I fixed the repo to be usable on windows and actually testing, it seems like the version expired (?) or was deleted. Either way, bumping its patch only (as it uses 0ver and any further bumps technically are major)

@vladfrangu vladfrangu requested a review from B4nan January 12, 2024 15:11
@vladfrangu vladfrangu added the adhoc Ad-hoc unplanned task added during the sprint. label Jan 12, 2024
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, this is so fragile, we should really make this package public so we can keep the versions. if the changes wouldnt be breaking for us, i wouldnt mind, but sometimes they are...

cc @jbartadev is this something your team can handle or can we somehow help/do it ourselves?

@vladfrangu vladfrangu marked this pull request as draft January 12, 2024 15:44
@vladfrangu
Copy link
Member Author

vladfrangu commented Jan 12, 2024

Fun times ahead. Bumping this somehow broke dev completely, because ui-components's dependencies for some reason import apify/log down the chain, a module that was never intended for browsers from the looks of things... And the older version the master branch currently relies on doesn't exist anymore....

UPDATE 1: these cosmic rays need to stop, with the cached version I still have locally of ui-components, apify/log still comes through but DEV works!?

UPDATE 2: for some reason pinning it to a previous version made it work. This is...very fragile... we should ideally make these components either public or split them out of the private package

@vladfrangu vladfrangu marked this pull request as ready for review January 12, 2024 15:56
@jbartadev
Copy link
Member

jbartadev commented Jan 15, 2024

hmm, this is so fragile, we should really make this package public so we can keep the versions. if the changes wouldnt be breaking for us, i wouldnt mind, but sometimes they are...

cc @jbartadev is this something your team can handle or can we somehow help/do it ourselves?

@B4nan Yeah, let's make it public, it looks like it'll save us a lot of pain in the future. It'll require some dependencies removal from the package. We'll try to take a look at it ASAP.

@vladfrangu
Copy link
Member Author

I'll merge this as is for now, looking forward to moving to the public components 🙏

@vladfrangu vladfrangu merged commit 1b318aa into master Jan 15, 2024
5 checks passed
@vladfrangu vladfrangu deleted the chore/deps/attempt-fix-for-TC-MO branch January 15, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants