Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use --legacy-peer-deps in the CI #794

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix: use --legacy-peer-deps in the CI #794

merged 1 commit into from
Dec 14, 2023

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Dec 14, 2023

Installing the @apify-packages/ui-components package only works with the --legacy-peer-deps flag (and it broke our CI).

@barjin barjin added bug Something isn't working. adhoc Ad-hoc unplanned task added during the sprint. labels Dec 14, 2023
@barjin barjin requested a review from B4nan December 14, 2023 15:46
@barjin barjin self-assigned this Dec 14, 2023
@github-actions github-actions bot added this to the 78th sprint - Tooling team milestone Dec 14, 2023
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Dec 14, 2023
B4nan
B4nan approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we fix that package instead? 👀

@barjin
Copy link
Contributor Author

barjin commented Dec 14, 2023

cc @jbartadev ⬆️ 🙏🏽 ?

@barjin barjin merged commit 7f747fd into master Dec 14, 2023
5 checks passed
@barjin barjin deleted the fix/ci-legacy-peer-deps branch December 14, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan B4nan approved these changes

Assignees

@barjin barjin

Labels
adhoc Ad-hoc unplanned task added during the sprint. bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
78th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@barjin @B4nan