Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update base Docker images, improve Dockerfile section, fix 404s #631

Merged
merged 2 commits into from
Jul 11, 2023
Merged

feat: Update base Docker images, improve Dockerfile section, fix 404s #631

merged 2 commits into from
Jul 11, 2023

Conversation

fnesveda
Copy link
Member

This:

  • updates the Dockerfile page with an up-to-date table about our base Docker images
  • adds a note that Actor templates already contain the right Dockerfile for the usecase
  • fixes a lot of broken links

Closes #568, #580.

@fnesveda fnesveda added the t-platform Issues with this label are in the ownership of the platform team. label Jul 10, 2023
@fnesveda fnesveda added this to the 67th sprint - Platform team milestone Jul 10, 2023
@fnesveda fnesveda requested review from mtrunkat and B4nan July 10, 2023 09:59
@fnesveda fnesveda self-assigned this Jul 10, 2023
@fnesveda fnesveda linked an issue Jul 10, 2023 that may be closed by this pull request
Webhook documentation ref leading to 404 #580
Closed
@B4nan B4nan requested a review from vladfrangu July 11, 2023 07:44
mtrunkat
mtrunkat approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@mtrunkat mtrunkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

vladfrangu
vladfrangu approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit, but lgtm otherwiseee

sources/platform/actors/development/actor_definition/dockerfile.md Outdated Show resolved Hide resolved
@fnesveda fnesveda merged commit 52f4894 into master Jul 11, 2023
@fnesveda fnesveda deleted the feat/update-dockerfile-docs branch July 11, 2023 19:59
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@B4nan B4nan B4nan approved these changes

@mtrunkat mtrunkat mtrunkat approved these changes

Assignees

@fnesveda fnesveda

Labels
t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Milestone
67th sprint - Platform team
Development

Successfully merging this pull request may close these issues.

Webhook documentation ref leading to 404 Update Docs > Actors > Development > Actor definition > Dockerfile
4 participants
@fnesveda @mtrunkat @B4nan @vladfrangu