Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

(fix) fixed VS build #586

Merged
merged 1 commit into from
Aug 10, 2018
Merged

(fix) fixed VS build #586

merged 1 commit into from
Aug 10, 2018

Conversation

tjanc
Copy link
Contributor

@tjanc tjanc commented Aug 10, 2018

  • run debug builds on Appveyor
  • if tests fail, Appveyor fails
  • if tests fail, last 100 lines of drafter.log are dumped

Two bugs in tests surfaced:

  • test-Variant.cc: too strict assert
  • snowcrash tests: changed occurences of Resource resource = to const Resource& resource = due to invalid copy constructor of snowcrash::Resource; this suppresses issue Invalid copy constructor of snowcrash::Resource #585 but does not fix it

@kylef kylef merged commit 3b0b060 into master Aug 10, 2018
@kylef kylef deleted the tjanc/appveyor-fixes branch August 10, 2018 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants