-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds repeats to try and fix len(dns). Issue79 #251
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolve apel#64. i was unsure which part needed to be repeated so i just repeated the whole function until the message can be saved into the queue, im not sure if this is right though.
resolve apel#64. i have just repeated the procedure either until it works or until a new counter i introduced reaches 3 so there is a limit to the recursion
procedure repeates either until it works or until the counter reaches three to avoid infinite recursion
resolve apel#64 . repeats the procedure either until it works or until it has been repeated three times
resolve apel#64 . repeats the procedure either until it works or until it has been repeated three times
Conflicts: ssm/ssm2.py
resolve apel#64. loops the add calls until they work or until the for loop is exhausted. is something like this what you mean?
resolve apel#79 . i was unsure which part to loop so i just repeated the whole chunk within the try statement.
resolve apel#79 . i was unsure which part to loop so i just repeated the whole chunk within the try statement.
'signer': signer, | ||
'empaid': empaid, | ||
'error': err_msg}) | ||
name = self._inq.add({'body': extracted_msg, |
Check notice
Code scanning / CodeQL
Unused local variable
Variable name is not used.
name = self._inq.add({'body': extracted_msg, | ||
'signer': signer, | ||
'empaid': empaid}) | ||
except: |
Check notice
Code scanning / CodeQL
Except block handles 'BaseException'
Except block directly handles BaseException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #79 . I was unsure which part to loop so I looped everything within the try statement. I also had to move the finally statement so the file only closed after I looped.