Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds repeats to try and fix len(dns). Issue79 #251

Closed
wants to merge 12 commits into from

Conversation

DanielPerkins7
Copy link
Contributor

resolve #79 . I was unsure which part to loop so I looped everything within the try statement. I also had to move the finally statement so the file only closed after I looped.

DanielPerkins7 and others added 10 commits August 1, 2023 14:15
resolve apel#64.   i was unsure which part needed to be repeated so i just repeated the whole function until the message can be saved into the queue, im not sure if this is right though.
resolve apel#64. i have just repeated the procedure either until it works or until a new counter i introduced reaches 3 so there is a limit to the recursion
procedure repeates either until it works or until the counter reaches three to avoid infinite recursion
resolve apel#64  .  repeats the procedure either until it works or until it has been repeated three times
resolve apel#64  .  repeats the procedure either until it works or until it has been repeated three times
resolve apel#64. loops the add calls until they work or until the for loop is exhausted. is something like this what you mean?
resolve apel#79 . i was unsure which part to loop so i just repeated the whole chunk within the try statement.
@DanielPerkins7 DanielPerkins7 requested a review from a team as a code owner August 2, 2023 13:56
resolve apel#79 . i was unsure which part to loop so i just repeated the whole chunk within the try statement.
'signer': signer,
'empaid': empaid,
'error': err_msg})
name = self._inq.add({'body': extracted_msg,

Check notice

Code scanning / CodeQL

Unused local variable

Variable name is not used.
name = self._inq.add({'body': extracted_msg,
'signer': signer,
'empaid': empaid})
except:

Check notice

Code scanning / CodeQL

Except block handles 'BaseException'

Except block directly handles BaseException.
@DanielPerkins7 DanielPerkins7 deleted the issue79 branch August 2, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Receiver crashes if DNs file is being written to and read from at the same time.
1 participant