Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinkerGraphParameterizedWorld # useParametersLteraly() removes overried identifier #2956

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

haohao0103
Copy link

TinkerGraphParameterizedWorld # useParametersLteraly() removes overried identifier

TinkerGraphParameterizedWorld # useParametersLteraly() removes overried identifier
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.07%. Comparing base (cfd6889) to head (51f49e4).
Report is 56 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2956      +/-   ##
============================================
+ Coverage     77.87%   78.07%   +0.19%     
- Complexity    13578    13889     +311     
============================================
  Files          1015     1019       +4     
  Lines         59308    59816     +508     
  Branches       6835     6925      +90     
============================================
+ Hits          46184    46699     +515     
+ Misses        10817    10798      -19     
- Partials       2307     2319      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cole-Greer
Copy link
Contributor

Thanks for opening the PR @haohao0103, could you expand on your reasons for removing the @Override annotation here? This method is overriding the implementation from the World class

@Cole-Greer
Copy link
Contributor

Sorry I saw this PR before seeing the associated JIRA: TINKERPOP-3123. Let's continue the discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants