Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Default Matrix Multiplication specializations #2212

Closed
wants to merge 5 commits into from

Conversation

Baunsgaard
Copy link
Contributor

No description provided.

This commit adds specializations for matrix multiplication with:

1. dense-sparse with sparse output
2. ultra sparse out dense dense in.
3. sparse out on sparse vector right side in.

Furthermore, i modified the call stack to branch to native mm
inside LibMatrixMult, to allow easy native support for CLA, by calling
LibMatrixMult, instead of having to go though a MatrixBlock.
@Baunsgaard
Copy link
Contributor Author

This PR adds specializations for matrix multiplication with:

  1. dense-sparse with sparse output
  2. ultra sparse out dense dense in.
  3. sparse out on sparse vector right side in.

Furthermore, i modified the call stack to branch to native mm
inside LibMatrixMult, to allow easy native support for CLA, by calling
LibMatrixMult, instead of having to go though a MatrixBlock.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 92.13483% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.41%. Comparing base (2e1147a) to head (2f5c03c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...pache/sysds/runtime/matrix/data/LibMatrixMult.java 93.10% 2 Missing and 4 partials ⚠️
...che/sysds/runtime/matrix/data/LibMatrixNative.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2212      +/-   ##
============================================
+ Coverage     72.38%   72.41%   +0.02%     
- Complexity    45319    45367      +48     
============================================
  Files          1467     1467              
  Lines        170606   170710     +104     
  Branches      33257    33286      +29     
============================================
+ Hits         123494   123619     +125     
+ Misses        37724    37700      -24     
- Partials       9388     9391       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Baunsgaard Baunsgaard closed this in fd1ba7c Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant