Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Menu): Upgrade Menu Component to Ant Design 5 #31699

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

refactor(Menu): Upgrade Menu Component to Ant Design 5 #31699

wants to merge 5 commits into from

Conversation

geido
Copy link
Member

@geido geido commented Jan 3, 2025

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@korbit-ai Korbit AI
Copy link

korbit-ai bot commented Jan 3, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@geido geido force-pushed the geido/refactor/antd5-upgrade-menu branch from 2e268ad to c595454 Compare January 6, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadpandajoe sadpandajoe Awaiting requested review from sadpandajoe sadpandajoe will be requested when the pull request is marked ready for review sadpandajoe is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho will be requested when the pull request is marked ready for review eschutho is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas will be requested when the pull request is marked ready for review rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida will be requested when the pull request is marked ready for review betodealmeida is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
review:draft size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geido @sadpandajoe