Skip to content

Commit

Permalink
fs-loader: Moving importing of initfunc declarations from header (fs-…
Browse files Browse the repository at this point in the history
…loader.h)

to the source (fs-loader.c).

fs-loader.h is a header which should be included into all implementations
of FS libraries, where we should not have initfuncs of other modules, while
fs-loader.c is the only source file using them.

* subversion/libsvn_fs/fs-loader.h
  (include of initfuncs): from here...
* subversion/libsvn_fs/fs-loader.c
  (includes): Move there.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1920823 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
rinrab committed Sep 21, 2024
1 parent 1a43862 commit 469af2a
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
12 changes: 12 additions & 0 deletions subversion/libsvn_fs/fs-loader.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,18 @@

#include "fs-loader.h"

/* Here are the declarations for the FS module init functions. If we
are using DSO loading, they won't actually be linked into
libsvn_fs. Note that these private functions have a common_pool
parameter that may be used for fs module scoped variables such as
the bdb cache. This will be the same common_pool that is passed
to the create and open functions and these init functions (as well
as the open and create functions) are globally serialized so that
they have exclusive access to the common_pool. */
#include "../libsvn_fs_base/fs_init.h"
#include "../libsvn_fs_fs/fs_init.h"
#include "../libsvn_fs_x/fs_init.h"

/* This is defined by configure on platforms which use configure, but
we need to define a fallback for Windows. */
#ifndef DEFAULT_FS_TYPE
Expand Down
12 changes: 0 additions & 12 deletions subversion/libsvn_fs/fs-loader.h
Original file line number Diff line number Diff line change
Expand Up @@ -183,18 +183,6 @@ typedef svn_error_t *(*fs_init_func_t)(const svn_version_t *loader_version,
fs_library_vtable_t **vtable,
apr_pool_t* common_pool);

/* Here are the declarations for the FS module init functions. If we
are using DSO loading, they won't actually be linked into
libsvn_fs. Note that these private functions have a common_pool
parameter that may be used for fs module scoped variables such as
the bdb cache. This will be the same common_pool that is passed
to the create and open functions and these init functions (as well
as the open and create functions) are globally serialized so that
they have exclusive access to the common_pool. */
#include "../libsvn_fs_base/fs_init.h"
#include "../libsvn_fs_fs/fs_init.h"
#include "../libsvn_fs_x/fs_init.h"



/*** vtable types for the abstract FS objects ***/
Expand Down

0 comments on commit 469af2a

Please sign in to comment.