Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17066: Add deprecation warnings to 9x methods #2302

Merged

Conversation

gerlowskija
Copy link
Contributor

@gerlowskija gerlowskija commented Feb 26, 2024

https://issues.apache.org/jira/browse/SOLR-17066

Description

In PR #2283, SOLR-17066 introduced the LBSolrClient.Endpoint class, and modified several "LB" client methods to use it on "main". Users who take advantage of these methods in Solr 9 should be given proper notice that they'll be changing (or going away entirely) in Solr 10.

Solution

This commit adds the corresponding deprecation notices to branch_9x, so that users can be notified of these changes and start to upgrade their apps where appropriate/required.

Tests

N/A - doc change only.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against branch_9x branch.
  • I have run ./gradlew check.
  • I have added documentation for the Reference Guide

SOLR-17066 introduced the `LBSolrClient.Endpoint` class, and modified
several "LB" client methods to use it on "main".  This commit adds the
corresponding deprecation notices to branch_9x, so that users can be
notified of these changes and start to upgrade their apps where
appropriate/required.

This commit should only be added to branch_9x.
@gerlowskija gerlowskija merged commit a139617 into apache:branch_9x Mar 4, 2024
1 check passed
@gerlowskija gerlowskija deleted the SOLR-17066-9x-deprecation-notices branch March 4, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant