SOLR-17058: Request param to disable distributed stats request at query time #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 20, 2023 15:08
mkhludnev
requested changes
Nov 22, 2023
There was a problem hiding this comment.
@weiwang19 thank you so much for the contribution! I think it's worthwhile to add. I want to share my opinion, it's quite flexible though.
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java
Outdated
Show resolved
Hide resolved
solr/core/src/test/org/apache/solr/search/stats/TestDistribIDF.java
Outdated
Show resolved
Hide resolved
solr/solrj/src/java/org/apache/solr/common/params/CommonParams.java
Outdated
Show resolved
Hide resolved
added 3 commits
November 27, 2023 22:07
mkhludnev
reviewed
Nov 28, 2023
solr/solr-ref-guide/modules/deployment-guide/pages/solrcloud-distributed-requests.adoc
Outdated
Show resolved
Hide resolved
|
Thanks @weiwang19 |
|
please let me know if there are any concerns to address. |
pls check weiwang19#1 |
SOLR-170588: more explicit asserts
github-actions
bot
added
documentation
|
Done with the changes. Thank you so much @mkhludnev |
mkhludnev
approved these changes
Feb 21, 2024
|
Thanks, @weiwang19. Would you mind to create cherrypick PR to branch_9x? |
weiwang19
added a commit
to weiwang19/solr
that referenced
this pull request
Feb 21, 2024
…ry time (apache#2046) * add param to disable distrib stats at query time --------- Co-authored-by: wwang30 <[email protected]> Co-authored-by: Mikhail Khludnev <[email protected]>
|
@mkhludnev can you help check the PR for backport to 9x? #2291 |
mkhludnev
added a commit
that referenced
this pull request
Feb 21, 2024
…ry time (#2291) * SOLR-17058: Request param to disable distributed stats request at query time (#2046) Co-authored-by: wwang30 <[email protected]> Co-authored-by: Mikhail Khludnev <[email protected]>
mkhludnev
added a commit
that referenced
this pull request
Mar 15, 2024
…alStatsCache (#2332) follow up SOLR-17058 (#2046)
mkhludnev
added a commit
to mkhludnev/solr
that referenced
this pull request
Mar 15, 2024
…alStatsCache (apache#2332) follow up SOLR-17058 (apache#2046)
mkhludnev
added a commit
that referenced
this pull request
Mar 15, 2024
…alStatsCache (#2332) (#2350) follow up SOLR-17058 (#2046)
alessandrobenedetti
pushed a commit
to SeaseLtd/solr
that referenced
this pull request
Mar 18, 2024
…alStatsCache (apache#2332) follow up SOLR-17058 (apache#2046)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17058
Description
When distributed IDF is enabled in solr cloud by adding one of the cache implementations in solrconfig.xml https://solr.apache.org/guide/solr/latest/deployment-guide/solrcloud-distributed-requests.html#distributedidf, each solr query will incur a distributed shard request to get term statistics. For queries that does not use distributed IDF information for scoring, the stats request is not necessary.
Solution
Hence I propose to add a distrib.statsCache request param so that the distributed stats request can be disabled at query time.
Tests
Added unit tests related to distrib IDF and query result key.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.