Fix the issue with deleting the "Host" header #5781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The host cannot be customized
The host cannot be customized
|
why delete 'Host' from http header |
The original logic ends up removing the ‘Host’ header, which causes any custom ‘Host’ header functionality in the request plugin to fail. My recommendation is to remove the code that deletes ‘Host’ to allow the plugin to function correctly, increasing flexibility without forcing the removal of the ‘Host’ header. Alternatively, this could be made configurable, either in the request setup or the service discovery. In any case, forcing the deletion of ‘Host’ in code is not ideal. Please also refer to the details in my submitted issue for further clarification. |
titxue
commented
Nov 16, 2024
|
not right |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5780