Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][JDBC source] pg support char types #8420

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

xyq2834646405
Copy link

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@xyq2834646405 xyq2834646405 changed the title [Feature][JDBC source] pg support char types (#8300) [Feature][JDBC source] pg support char types #8300 Jan 2, 2025
@xyq2834646405 xyq2834646405 changed the title [Feature][JDBC source] pg support char types #8300 [Feature][JDBC source] pg support char types Jan 2, 2025
Copy link
Contributor

@SimonChou12138 SimonChou12138 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, in PG, the char type will be read as bpchar type in metadata. Of course, I think this modification can avoid some compatibility issues with different versions of PG.

Copy link
Contributor

@SimonChou12138 SimonChou12138 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
cc @Hisoka-X

@Hisoka-X
Copy link
Member

Hisoka-X commented Jan 2, 2025

Please enable test case.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants