-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][kafka] use config to set kafka deserialize error ignore parameter #8377
base: dev
Are you sure you want to change the base?
Conversation
boolean ignoreParseErrors = | ||
readonlyConfig | ||
.get(MESSAGE_FORMAT_ERROR_HANDLE_WAY_OPTION) | ||
.equals(MessageFormatErrorHandleWay.SKIP); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it is necessary to add some logging for this action, as it is a risky move
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will add it. Thanks point this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some unit test?
When I write the test, I find the behavior in different implement is difference. When the record has miss match column value or something else, Some Implement will sucessful execute, the error column value put |
It should be control by Line 102 in 71ab848
|
Purpose of this pull request
now, some desrialize use hardcode value to set the
deserialize error ignore
value.actually we have this config, use config to set the value
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.