Add stack info when consuming fail (#1164)

* fix can't send batch message error * log stack info when consume fail --------- Co-authored-by: tiger lee <[email protected]> Co-authored-by: tigerweili <[email protected]>
apache · Nov 28, 2024 · 8a0459a · 8a0459a
1 parent 3538144
commit 8a0459a
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/consumer/push_consumer.go b/consumer/push_consumer.go
@@ -1113,6 +1113,7 @@ func (pc *pushConsumer) consumeMessageConcurrently(pq *processQueue, mq *primiti
 				if err := recover(); err != nil {
 					rlog.Error("consumeMessageConcurrently panic", map[string]interface{}{
 						rlog.LogKeyUnderlayError: err,
+						rlog.LogKeyStack:         utils.GetStackAsString(false),
 						rlog.LogKeyConsumerGroup: pc.consumerGroup,
 					})
 				}

diff --git a/internal/remote/remote_client.go b/internal/remote/remote_client.go
@@ -21,6 +21,7 @@ import (
 	"bytes"
 	"context"
 	"encoding/binary"
+	"github.com/apache/rocketmq-client-go/v2/internal/utils"
 	"io"
 	"net"
 	"sync"
@@ -286,7 +287,8 @@ func (c *remotingClient) createScanner(r io.Reader) *bufio.Scanner {
 		defer func() {
 			if err := recover(); err != nil {
 				rlog.Error("scanner split panic", map[string]interface{}{
-					"panic": err,
+					rlog.LogKeyUnderlayError: err,
+					rlog.LogKeyStack:         utils.GetStackAsString(false),
 				})
 			}
 		}()

diff --git a/internal/utils/errors.go b/internal/utils/errors.go
@@ -19,6 +19,7 @@ package utils
 
 import (
 	"github.com/apache/rocketmq-client-go/v2/rlog"
+	"runtime"
 )
 
 func CheckError(action string, err error) {
@@ -28,3 +29,8 @@ func CheckError(action string, err error) {
 		})
 	}
 }
+func GetStackAsString(all bool) string {
+	buf := make([]byte, 1<<10)
+	stackSize := runtime.Stack(buf, all)
+	return string(buf[:stackSize])
+}
diff --git a/rlog/log.go b/rlog/log.go
@@ -44,6 +44,7 @@ const (
 	LogKeyQueueId              = "queueId"
 	LogKeyQueueOffset          = "queueOffset"
 	LogKeyMessages             = "messages"
+	LogKeyStack                = "stack"
 )
 
 type Logger interface {