-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare to integrate new scheduler into apache/openwhisk-deploy-kube #5278
Conversation
1711ee7
to
2312798
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5278 +/- ##
==========================================
- Coverage 81.03% 76.42% -4.61%
==========================================
Files 239 239
Lines 14245 14249 +4
Branches 594 602 +8
==========================================
- Hits 11543 10890 -653
- Misses 2702 3359 +657 ☔ View full report in Codecov by Sentry. |
Apologies for making the PR live - then draft - then live again, but I believe it is in a good state now and ready for review! |
Hi Erika, have you filed an Individual Contributors License Agreement with Apache (https://www.apache.org/licenses/contributor-agreements.html#clas)? I did a quick search and I don't think I found one for you, but the tooling isn't always perfect. If you haven't done so already please go ahead and do that. |
@dgrove-oss I did submit an ICLA in the past, so I should be good to go. To be on the safe side and check for clerical errors, I have sent an email asking for confirmation that my form is on file. |
ok, cool. That's fine then. The tool for looking up ICLAs changed recently. Now you have to search by email address instead of by name and I haven't figured out how to do fuzzy searches yet. |
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Controller.scala
Outdated
Show resolved
Hide resolved
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/Scheduler.scala
Show resolved
Hide resolved
9d025b5
to
22d4da8
Compare
Rebased to master so I can make sure new changes integrate well into openwhisk-deploy-kube, also - I did confirm my ICLA is good. |
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Controller.scala
Outdated
Show resolved
Hide resolved
62dee68
to
c6284af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally agree with the direction of this PR.
I just wanted to make sure only the required logic is added.
Signed-off-by: Erika Hunhoff <[email protected]>
Signed-off-by: Erika Hunhoff <[email protected]>
c04a9b4
to
806cbe7
Compare
Rebased to master, finished addressing comments about changes to controller (by removing changes to the controller) |
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/Scheduler.scala
Show resolved
Hide resolved
Thank you, Erika, for your effort. 👍 |
…pache#5278) * Kubernetes Akka bootstrap for controller * Update cluster management for the scheduler to help with k8s deployment * Made changes to tools to try to integrate scheduler into travis/CI build process * Added scheduler Dockerfile.cov * Use consistent ordering of components * remove canonical.port setting in scheduler, controller * Remove unneeded dependency from controller, scheduler * Remove cluster creation from ShardingContainerPoolBalancer * Remove trailing whitespace Signed-off-by: Erika Hunhoff <[email protected]> * Revert akka cluster changes to controller Signed-off-by: Erika Hunhoff <[email protected]> Signed-off-by: Erika Hunhoff <[email protected]>
Description
I am working on integrating the new scheduler into openwhisk-deploy-kube (see this draft PR here). While most of the changes that need to be made are within the apache/openwhisk-deploy-kube repo, some changes need to be made here for full support.
Namely:
I tested locally (mostly using Kubernetes deployments) but I'm not sure the best way to test the tooling and changes to travis/CI.
Note that while I did, in general, try to integrate the scheduler into the tooling, I did not attempt to add it to
dev/src/main/groovy/intellijRunConfig.groovy
, as I don't have experience in this area.My changes affect the following components
Types of changes
Checklist: