Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-2506 Fix a gcc warning #1912

Closed
wants to merge 1 commit into from
Closed

MINIFICPP-2506 Fix a gcc warning #1912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion extensions/python/pythonlibloader/PythonLibLoader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ class PythonLibLoader {
static std::string execCommand(const std::string& cmd) {
std::array<char, 128> buffer{};
std::string result;
std::unique_ptr<FILE, decltype(&pclose)> pipe(popen(cmd.c_str(), "r"), pclose);
struct pclose_deleter { void operator()(FILE* file) noexcept { pclose(file); } };
std::unique_ptr<FILE, pclose_deleter> pipe{popen(cmd.c_str(), "r")};
if (!pipe) {
return "";
}
Expand Down