MINIFICPP-2471 SegmentContent #1879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinzink
force-pushed
the
MINIFICPP-2471_segmentcontent
branch
2 times, most recently
from
02e6107 to
a29f971
Compare
szaszm
reviewed
Oct 15, 2024
adamdebreceni
approved these changes
Oct 16, 2024
szaszm
approved these changes
Oct 16, 2024
fgerlits
reviewed
Oct 17, 2024
extensions/standard-processors/tests/unit/SegmentContentTests.cpp
Outdated
Show resolved
Hide resolved
fgerlits
reviewed
Oct 17, 2024
fgerlits
approved these changes
Oct 18, 2024
szaszm
reviewed
Oct 18, 2024
extensions/standard-processors/tests/unit/SegmentContentTests.cpp
Outdated
Show resolved
Hide resolved
martinzink
force-pushed
the
MINIFICPP-2471_segmentcontent
branch
from
e830b8b to
a078ca2
Compare
szaszm
approved these changes
Oct 21, 2024
lordgamez
approved these changes
Oct 22, 2024
Comment on lines
40
to
41
| const std::string fragment_identifier_ = original.getAttribute(core::SpecialFlowAttribute::UUID).value_or(utils::IdGenerator::getIdGenerator()->generate().to_string()); | ||
| const auto original_filename_ = original.getAttribute(core::SpecialFlowAttribute::FILENAME).value_or(""); |
There was a problem hiding this comment.
nitpick: we could remove the underscore suffix
martinzink
force-pushed
the
MINIFICPP-2471_segmentcontent
branch
from
a078ca2 to
d9f536d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.