Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-2467 MINIFICPP-2468 PutCouchbaseKey processor and controller #1875

Closed
wants to merge 16 commits into from

Conversation

lordgamez
Copy link
Contributor

@lordgamez lordgamez commented Oct 8, 2024

Introduces Couchbase extension with support for inserting data to Couchbase DB using PutCouchbaseKey processor using username/password authentication through CouchbaseClusterService controller service.

This PR also upgrades the following thirdparty libraries:

  • Spdlog 1.12.0 -> 1.14.1
  • Fmt 10.1.0 -> 11.0.2

https://issues.apache.org/jira/browse/MINIFICPP-2467
https://issues.apache.org/jira/browse/MINIFICPP-2468


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@lordgamez lordgamez marked this pull request as ready for review October 8, 2024 12:30
@lordgamez lordgamez force-pushed the MINIFICPP-2467 branch 2 times, most recently from bbfa6f6 to fa73512 Compare October 10, 2024 08:18
@lordgamez lordgamez marked this pull request as draft October 14, 2024 14:44
@lordgamez lordgamez force-pushed the MINIFICPP-2467 branch 2 times, most recently from f0b83dc to b7278a9 Compare October 14, 2024 18:42
@lordgamez
Copy link
Contributor Author

Added Document Type property for storing type metadata for inserted values in 25a84f8. They are used by type specific transcoders when retrieving values from the DB.

@lordgamez lordgamez marked this pull request as ready for review October 14, 2024 18:45
@martinzink
Copy link
Member

Could you also update the README.md's extension table?

@lordgamez
Copy link
Contributor Author

Could you also update the README.md's extension table?

Good catch, updated in dccd6ab

Copy link
Member

@martinzink martinzink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some CI failures that seems related otherwise LGTM

@lordgamez lordgamez force-pushed the MINIFICPP-2467 branch 3 times, most recently from 6fa4372 to 30fea42 Compare November 18, 2024 16:07
LICENSE Outdated Show resolved Hide resolved
thirdparty/bustache/add-append.patch Outdated Show resolved Hide resolved
libminifi/include/Exception.h Outdated Show resolved Hide resolved
thirdparty/couchbase/remove-thirdparty.patch Outdated Show resolved Hide resolved
extensions/couchbase/processors/PutCouchbaseKey.h Outdated Show resolved Hide resolved
@szaszm szaszm closed this in bd1182e Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants