-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIFICPP-2467 MINIFICPP-2468 PutCouchbaseKey processor and controller #1875
Conversation
docker/test/integration/cluster/containers/CouchbaseServerContainer.py
Outdated
Show resolved
Hide resolved
docker/test/integration/cluster/containers/CouchbaseServerContainer.py
Outdated
Show resolved
Hide resolved
extensions/couchbase/controllerservices/CouchbaseClusterService.cpp
Outdated
Show resolved
Hide resolved
extensions/couchbase/controllerservices/CouchbaseClusterService.cpp
Outdated
Show resolved
Hide resolved
bbfa6f6
to
fa73512
Compare
extensions/couchbase/controllerservices/CouchbaseClusterService.cpp
Outdated
Show resolved
Hide resolved
f0b83dc
to
b7278a9
Compare
Added Document Type property for storing type metadata for inserted values in 25a84f8. They are used by type specific transcoders when retrieving values from the DB. |
Could you also update the README.md's extension table? |
114eed0
to
dccd6ab
Compare
Good catch, updated in dccd6ab |
dccd6ab
to
9dd8d01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some CI failures that seems related otherwise LGTM
76b84fe
to
d12fc1b
Compare
d12fc1b
to
564c431
Compare
extensions/couchbase/controllerservices/CouchbaseClusterService.h
Outdated
Show resolved
Hide resolved
extensions/couchbase/controllerservices/CouchbaseClusterService.cpp
Outdated
Show resolved
Hide resolved
extensions/couchbase/controllerservices/CouchbaseClusterService.cpp
Outdated
Show resolved
Hide resolved
6fa4372
to
30fea42
Compare
extensions/couchbase/controllerservices/CouchbaseClusterService.cpp
Outdated
Show resolved
Hide resolved
extensions/couchbase/controllerservices/CouchbaseClusterService.h
Outdated
Show resolved
Hide resolved
30fea42
to
d2f1aed
Compare
d2f1aed
to
e99afe0
Compare
Introduces Couchbase extension with support for inserting data to Couchbase DB using PutCouchbaseKey processor using username/password authentication through CouchbaseClusterService controller service.
This PR also upgrades the following thirdparty libraries:
https://issues.apache.org/jira/browse/MINIFICPP-2467
https://issues.apache.org/jira/browse/MINIFICPP-2468
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.