NbTestCase method ordering is always using "natural" order.

- disable tests
apache · Jan 31, 2024 · 552f4f8 · 552f4f8
1 parent 8f0d8c6
commit 552f4f8
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/harness/nbjunit/src/org/netbeans/junit/MethodOrder.java b/harness/nbjunit/src/org/netbeans/junit/MethodOrder.java
@@ -43,6 +43,9 @@ static void initialize() {
         String orderS = findOrder();
         if (!"natural".equals(orderS)) { // NOI18N
             try {
+                // TODO: ClassLoader fields can not be accessed via reflection on JDK 12+
+                // see jdk.internal.reflect.Reflection#fieldFilterMap
+                // this won't work
                 Field classesF = ClassLoader.class.getDeclaredField("classes"); // NOI18N
                 classesF.setAccessible(true);
                 @SuppressWarnings("unchecked")
@@ -53,6 +56,7 @@ static void initialize() {
                     }
                 }
             } catch (Exception x) {
+                System.err.println("WARNING: test method ordering disabled");
                 x.printStackTrace();
             }
         }

diff --git a/harness/nbjunit/test/unit/src/org/netbeans/junit/OrderAZTest.java b/harness/nbjunit/test/unit/src/org/netbeans/junit/OrderAZTest.java
@@ -22,6 +22,7 @@
 import junit.framework.TestResult;
 import junit.framework.TestSuite;
 import org.junit.Assert;
+import org.junit.Ignore;
 import org.junit.Test;
 
 /** Check the a-z behaviour.
@@ -33,6 +34,8 @@ public class OrderAZTest {
         System.setProperty("NbTestCase.order", "a-z");
     }
 
+    // method order isn't working, see comment in org.netbeans.junit.MethodOrder
+    @Ignore
     @Test public void shuffleTest() throws ClassNotFoundException {
         Class<?> load = Class.forName("org.netbeans.junit.OrderHid");
         TestSuite ts = new TestSuite(load);

diff --git a/harness/nbjunit/test/unit/src/org/netbeans/junit/OrderTest.java b/harness/nbjunit/test/unit/src/org/netbeans/junit/OrderTest.java
@@ -32,7 +32,7 @@ public class OrderTest {
     static {
         System.setProperty("NbTestCase.order", "1314372086210");
     }
-    
+
     @Test public void shuffleTest() throws ClassNotFoundException {
         Class<?> load = Class.forName("org.netbeans.junit.OrderHid");
         TestSuite ts = new TestSuite(load);

diff --git a/harness/nbjunit/test/unit/src/org/netbeans/junit/OrderZATest.java b/harness/nbjunit/test/unit/src/org/netbeans/junit/OrderZATest.java
@@ -22,6 +22,7 @@
 import junit.framework.TestResult;
 import junit.framework.TestSuite;
 import org.junit.Assert;
+import org.junit.Ignore;
 import org.junit.Test;
 
 /** Check the z-a behaviour.
@@ -33,6 +34,8 @@ public class OrderZATest {
         System.setProperty("NbTestCase.order", "z-a");
     }
 
+    // method order isn't working, see comment in org.netbeans.junit.MethodOrder
+    @Ignore
     @Test public void shuffleTest() throws ClassNotFoundException {
         Class<?> load = Class.forName("org.netbeans.junit.OrderHid");
         TestSuite ts = new TestSuite(load);