Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucene.Net.Util.Events.TestPubSubEvent::CanAddSubscriptionWhileEventIsFiringNonGeneric(): Added [Ignore] attribute #1107

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

NightOwl888
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Lucene.Net.Util.Events.TestPubSubEvent::CanAddSubscriptionWhileEventIsFiringNonGeneric(): Added [Ignore] attribute.

See #998

Description

Lucene.Net.Util.Events.TestPubSubEvent::CanAddSubscriptionWhileEventIsFiringNonGeneric(): Added [Ignore] attribute, as this only applies prior to .NET Standard 2.1 and was an inherited problem from Prism.Core. This problem will eventually go away when every target below netstandard2.1 is dropped and it doesn't seem like a priority to fix it unless a user reports a problem related to using weak events as a workaround to the fact that ConditionalWeakTable<TKey, TValue> didn't have an enumerator in older target frameworks.

…sFiringNonGeneric(): Added [Ignore] attribute, as this only applies prior to .NET Standard 2.1 and was an inherited problem from Prism.Core.
@NightOwl888 NightOwl888 added the notes:ignore Don't show this PR in the Release Notes label Jan 20, 2025
@NightOwl888 NightOwl888 requested a review from paulirwin January 20, 2025 15:18
@NightOwl888 NightOwl888 merged commit 4acbde3 into apache:master Jan 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes:ignore Don't show this PR in the Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants