Use Arrays#mismatch for Outputs#common operations #12710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dungba88
reviewed
Oct 23, 2023
| // no common prefix | ||
| return NO_OUTPUT; | ||
| } else if (pos1 == output1.offset + output1.length) { | ||
| } else if (mismatchPos == -1) { |
There was a problem hiding this comment.
Why aren't we merging these 2 branches?
else if (mismatchPos == -1 || mismatchPos == output1.length)
There was a problem hiding this comment.
Just for better comment to explain. Will merge if you think this way is better :)
There was a problem hiding this comment.
Either way would look good to me.
dungba88
reviewed
Oct 23, 2023
| // output2 is a prefix of output1 | ||
| return output2; | ||
| } else { | ||
| return new IntsRef(output1.ints, output1.offset, pos1 - output1.offset); | ||
| return new IntsRef(output1.ints, output1.offset, mismatchPos); |
There was a problem hiding this comment.
I had a previous comment about this length parameter, but it seems mismatchPos will return the relative index, so that's ok. Just added here for posterity.
jpountz
approved these changes
Oct 23, 2023
dungba88
approved these changes
Oct 23, 2023
asfgit
pushed a commit
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
Outputs#commontake advantage ofArrays#mismatch.