KAFKA-18311: Configuring changelog topics (2/N) #18379
Open
+834
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cadonna could you have a look? |
cadonna
reviewed
Jan 6, 2025
Comment on lines
35
to
38
| /** | ||
| * This class is responsible for setting up the changelog topics for a topology. | ||
| */ |
There was a problem hiding this comment.
Could you please add some more details?
| private final Collection<Subtopology> subtopologies; | ||
| private final Function<String, Integer> topicPartitionCountProvider; | ||
|
|
||
| public ChangelogTopics( |
There was a problem hiding this comment.
Could you please add javadocs?
Especially for the topicPartitionCountProvider.
|
|
||
| private int getPartitionCountOrFail(String topic) { | ||
| final Integer topicPartitionCount = topicPartitionCountProvider.apply(topic); | ||
| if (topicPartitionCount == null) { |
There was a problem hiding this comment.
Should the topicPartitionCountProvider return an Optional instead of an Integer?
lucasbru
force-pushed
the
kip1071merge/topic_config2
branch
from
4cc3b4b to
acb8145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simplified port of "ChangelogTopics" from the client-side to the group coordinator
Compared to the client-side version, the implementation uses immutable data structures, and returns the computed number of partitions instead of modifying mutable data structures and calling the admin client.
Stacked PR, only review last commit.
Committer Checklist (excluded from commit message)