Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-17915: Convert remaining Kafka Client system tests to use KRaft #18367

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

kevin-wu24
Copy link
Contributor

@kevin-wu24 kevin-wu24 commented Dec 31, 2024

Convert tests/kafkatest/tests/client/client_compatibility_features_test.py, tests/kafkatest/tests/client/client_compatibility_produce_consume_test.py, and
tests/kafkatest/tests/client/quota_test.pyto use KRaft.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community tests Test fixes (including flaky tests) small Small PRs labels Dec 31, 2024
Copy link

github-actions bot commented Jan 8, 2025

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

Copy link
Member

@lianetm lianetm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @kevin-wu24! Overall lgtm. Couple of comments:

Regarding the quota_test, since is being migrated to kraft with this PR, should we revise the force_use_zk_connection param it's still using?

Also, could you please run the updated test and share the output to validate the changes? Thanks!

@kevin-wu24
Copy link
Contributor Author

kevin-wu24 commented Jan 8, 2025

Thanks for the review @lianetm!

Regarding the quota_test, since is being migrated to kraft with this PR, should we revise the force_use_zk_connection param it's still using?

Yes, this boolean is always False, so we can remove it.

Also, could you please run the updated test and share the output to validate the changes? Thanks!

Link to system test run: https://semaphore.ci.confluent.io/workflows/6d93b69f-8d61-4b30-974b-09e092d276df passed

@github-actions github-actions bot removed needs-attention triage PRs from the community labels Jan 9, 2025
Copy link
Member

@lianetm lianetm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevin-wu24 ! LGTM.

@lianetm lianetm merged commit 25fdcd0 into apache:trunk Jan 9, 2025
9 checks passed
@lianetm
Copy link
Member

lianetm commented Jan 9, 2025

Merged to trunk and cherry-picked to 4.0

m1a2st pushed a commit to m1a2st/kafka that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants