-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR Remove needs-attention label after review #18366
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mumrah thanks for this patch
.github/workflows/pr-reviewed.yml
Outdated
@@ -57,6 +57,21 @@ jobs: | |||
issue_number: pull.number, | |||
name: "triage" | |||
}); | |||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why do we have extra logging specifically for removing the needs-attention label? We don't seem to have similar logging for other labels like triage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the issue search is filtering for label:triage
, we know all the found PRs will have that label. We do log something for each of this (on L53)
console.log("Removing 'triage' label from PR " + pull.number + " : " + pull.title);
To be consistent, I thought we should log a message when we remove "needs-attention".
This log line is a bit extraneous. I'll remove it
console.log("PR did not have 'needs-attention' label");
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To ensure both "removeLabel" are executed, should we implement error handling for removing "triage"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this actually makes me realize that triage
could be missing. I've modified the workflow to search for both labels separately.
Follow up from #18147 to also remove the needs-attention label