KAFKA-18370:Fix to Kraft or remove tests associate with Zk Broker config in ReplicaFetcherThreadTest #18354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
chia7712
reviewed
Jan 4, 2025
| @@ -140,85 +118,6 @@ class ReplicaFetcherThreadTest { | |||
| ) | |||
| } | |||
|
|
|||
| @Test | |||
| def testFetchLeaderEpochRequestIfLastEpochDefinedForSomePartitions(): Unit = { | |||
There was a problem hiding this comment.
why to remove this test case? it happens only on zk broker?
There was a problem hiding this comment.
These test is already remove by another PR.
| @@ -353,217 +246,13 @@ class ReplicaFetcherThreadTest { | |||
| assertEquals(3, mockNetwork.fetchCount) | |||
| } | |||
|
|
|||
| @Test | |||
| def shouldTruncateToOffsetSpecifiedInEpochOffsetResponse(): Unit = { | |||
There was a problem hiding this comment.
These test is already remove by another PR.
|
These tests will be removed after 4.0. |
FrankYang0529
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Committer Checklist (excluded from commit message)