-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: doc change for minisr to clarify replicas in Kafka Config #11163
base: trunk
Are you sure you want to change the base?
Conversation
LGTM, had one comment |
Co-authored-by: Joel Hamill <[email protected]>
This PR is being marked as stale since it has not had any activity in 90 days. If you If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact). If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
@pdruley can you please fix the conflict and we can work towards merging this PR. |
I resolved the conflict but where are the docs for the configuration settings now? |
Here: kafka/server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java Line 138 in 40890fa
|
This is a minor doc change to MinInSyncReplicasDoc to clarify what is a replica and further help users understand the importance of this configuration in relation to their producer configuration.
It didn't seem like a Jira was necessary but I am open to creating one if needed. I did not compile from source to test, no other code was changed.
This contribution is my original work and I license the work to the project under the project's open source license.
Thanks!
Committer Checklist (excluded from commit message)