Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: doc change for minisr to clarify replicas in Kafka Config #11163

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

pdruley
Copy link

@pdruley pdruley commented Aug 2, 2021

This is a minor doc change to MinInSyncReplicasDoc to clarify what is a replica and further help users understand the importance of this configuration in relation to their producer configuration.

It didn't seem like a Jira was necessary but I am open to creating one if needed. I did not compile from source to test, no other code was changed.

This contribution is my original work and I license the work to the project under the project's open source license.

Thanks!

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@joel-hamill
Copy link
Contributor

LGTM, had one comment

Copy link

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale Stale PRs label Dec 24, 2024
@divijvaidya
Copy link
Member

@pdruley can you please fix the conflict and we can work towards merging this PR.

@divijvaidya divijvaidya added docs and removed stale Stale PRs labels Jan 23, 2025
@github-actions github-actions bot added the small Small PRs label Jan 23, 2025
@pdruley
Copy link
Author

pdruley commented Jan 23, 2025

@pdruley can you please fix the conflict and we can work towards merging this PR.

I resolved the conflict but where are the docs for the configuration settings now?

@divijvaidya
Copy link
Member

@pdruley can you please fix the conflict and we can work towards merging this PR.

I resolved the conflict but where are the docs for the configuration settings now?

Here:

public static final String MIN_IN_SYNC_REPLICAS_DOC = "When a producer sets acks to \"all\" (or \"-1\"), " +

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs small Small PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants