Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-9491][Sort] CSV format support ignore trailing unmappable fields #9492

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

vernedeng
Copy link
Contributor

Prepare a Pull Request

(Change the title refer to the following example)

  • Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve?

Modifications

Describe the modifications you've done.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@vernedeng vernedeng requested a review from EMsnap December 15, 2023 09:16
@vernedeng vernedeng self-assigned this Dec 15, 2023
@vernedeng vernedeng changed the title [INLONG-9491]][Sort] Csv format support ignore trailing unmappable fields [INLONG-9491][Sort] Csv format support ignore trailing unmappable fields Dec 15, 2023
Copy link
Contributor

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are tests for FormatDecoder, could you please add a test for this case ?

@dockerzhang dockerzhang changed the title [INLONG-9491][Sort] Csv format support ignore trailing unmappable fields [INLONG-9491][Sort] CSV format support ignore trailing unmappable fields Dec 18, 2023
EMsnap
EMsnap previously approved these changes Jan 5, 2024
@EMsnap EMsnap merged commit f3963ba into apache:master Jan 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Sort] Csv format support ignore trailing unmappable fields
3 participants