Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11002][SDK] Transform SQL support Fibonacci function #11622

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

emptyOVO
Copy link
Contributor

Fixes #11002

Motivation

Add one arithmetic function classes:FibonacciFunction. Also, add the corresponding unit test codes
refer to pr #11003

Modifications

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

Copy link
Contributor

@Zkplo Zkplo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding some NP checks in parse().

@emptyOVO
Copy link
Contributor Author

Suggest adding some NP checks in parse().

thanks, done

@dockerzhang dockerzhang merged commit a31b09a into apache:master Dec 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][SDK] Transform SQL support Fibonacci function
5 participants